Change field include and exclude handling #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alegacy
force-pushed
the
feature/fix-field-filters
branch
from
aa48e97 to
aeed3de
Compare
alegacy
force-pushed
the
feature/fix-field-filters
branch
from
aeed3de to
14b3608
Compare
|
rebased |
alegacy
force-pushed
the
feature/fix-field-filters
branch
from
14b3608 to
4344449
Compare
This changes the implementation of the include/exclude field handling so that it is done explicitly in the API handlers rather than implicitly in the middleware layer. It also adds support for the "all_fields" query parameter. The response behavior will now be that any optional field that is nil will be excluded from responses unless the "all_fields" parameter is set, or the field name appears in the "fields=" query parameter. Signed-off-by: Allain Legacy <[email protected]>
alegacy
force-pushed
the
feature/fix-field-filters
branch
from
4344449 to
c079a0d
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlguerrero12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the implementation of the include/exclude field handling so that it is done explicitly in the API handlers rather than implicitly in the middleware layer. It also adds support for the "all_fields" query parameter.
The response behavior will now be that any optional field that is nil will be excluded from responses unless the "all_fields" parameter is set, or the field name appears in the "fields=" query parameter.