Update the integ tests jenkinsfile to enable base-path parameter #3553
Conversation
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3553 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 181 181
Lines 5369 5369
=======================================
Hits 4912 4912
Misses 457 457 |
| @@ -174,7 +174,7 @@ pipeline { | |||
| } | |||
| } catch (e) { | |||
| echo "Error running integtest for component ${local_component}, creating Github issue" | |||
| String issueBodyMessage = "The integration test failed at distribution level for component ${local_component}<br>Version: ${version}<br>Distribution: ${distribution}<br>Architecture: ${architecture}<br>Platform: ${platform}<br><br>Please check the logs: ${RUN_DISPLAY_URL}<br><br> * Steps to reproduce: See https://github.com/opensearch-project/opensearch-build/tree/main/src/test_workflow#integration-tests<br>* Access cluster logs:<br> - [With security](https://ci.opensearch.org/ci/dbc/${JOB_NAME}/${version}/${buildId}/${platform}/${architecture}/${distribution}/test-results/${BUILD_NUMBER}/integ-test/${local_component}/with-security/local-cluster-logs/stdout.txt) (if applicable)<br> - [Without security](https://ci.opensearch.org/ci/dbc/${JOB_NAME}/${version}/${buildId}/${platform}/${architecture}/${distribution}/test-results/${BUILD_NUMBER}/integ-test/${local_component}/without-security/local-cluster-logs/stdout.txt) (if applicable)<br><br> _Note: All in one test report manifest with all the details coming soon. See https://github.com/opensearch-project/opensearch-build/issues/1274_" | |||
| String issueBodyMessage = "The integration test failed at distribution level for component ${local_component}<br>Version: ${version}<br>Distribution: ${distribution}<br>Architecture: ${architecture}<br>Platform: ${platform}<br><br>Please check the logs: ${RUN_DISPLAY_URL}<br><br> * Steps to reproduce: See https://github.com/opensearch-project/opensearch-build/tree/main/src/test_workflow#integration-tests<br>* Access components yml file:<br> - [With security](https://ci.opensearch.org/ci/dbc/${JOB_NAME}/${version}/${buildId}/${platform}/${architecture}/${distribution}/test-results/${BUILD_NUMBER}/integ-test/${local_component}/with-security/${local_component}.yml) (if applicable)<br> - [Without security](https://ci.opensearch.org/ci/dbc/${JOB_NAME}/${version}/${buildId}/${platform}/${architecture}/${distribution}/test-results/${BUILD_NUMBER}/integ-test/${local_component}/without-security/${local_component}.yml) (if applicable)<br><br> _Note: All in one test report manifest with all the details coming soon. See https://github.com/opensearch-project/opensearch-build/issues/1274_" | |||
There was a problem hiding this comment.
This should have been changed too:
The integration test failed at distribution level for component ${local_component}<br>Version: ${version}<br>Distribution: ${distribution}<br>Architecture: ${architecture}<br>Platform: ${platform}<br><br>Please check the logs: ${RUN_DISPLAY_URL}<br><br> * Steps to reproduce: See https://github.com/opensearch-project/opensearch-build/tree/main/src/test_workflow#integration-tests<br>* Access components yml file:<br> -(https://ci.opensearch.org/ci/dbc/${JOB_NAME}/${version}/${buildId}/${platform}/${architecture}/${distribution}/test-results/${BUILD_NUMBER}/integ-test/${local_component}/with-security/${local_component}.yml) <br><br> _Note: All in one test report manifest with all the details coming soon. See https://github.com/opensearch-project/opensearch-build/issues/1274_
@zelinh Since this was merged too fast can you create another PR to fix this or @Divyaasm you can add this to yours.
Thanks!
There was a problem hiding this comment.
@gaiksaya What do you suggest this part to be changed to?
There was a problem hiding this comment.
Sure, let me know the changes needed to be made
There was a problem hiding this comment.
Updated the message to reflect it. Markdown flipped it.
Basically remove everything related to log files and just provide the component.yml.
There was a problem hiding this comment.
I think in this new issue, only component.yml would be attached along with the logs from our ci jenkins. No other logs would be included.
e.g. autocut issue: zelinh#60
There was a problem hiding this comment.
Right thats what I meant! We do not need with and without security too. Just synced up with @Divyaasm I believe she got it
There was a problem hiding this comment.
But there would be two component.ymls for with/without security. Not sure if our autocut issue library could differentiate the test configuration here though. I feel like we probably won't want to separate different test configurations to two issues for each plugin. Let me sync up with you or @Divyaasm offline then. Thanks.
Description
Update the integ tests jenkinsfile to enable base-path parameter
Issues Resolved
Part of #3499
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.