Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pure fetch in OSD for streaming output. #9592

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Draft

Support pure fetch in OSD for streaming output. #9592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/core/public/http/fetch.ts
View file
Original file line number Diff line number Diff line change
@@ -182,6 +182,9 @@

try {
response = await window.fetch(request);
if (fetchOptions.pureFetch) {
return { fetchOptions, request, response, body };

Check warning on line 186 in src/core/public/http/fetch.ts

Codecov / codecov/patch

src/core/public/http/fetch.ts#L186 

Added line #L186 was not covered by tests
}
} catch (err) {
throw new HttpFetchError(err.message, err.name ?? 'Error', request);
}
5 changes: 5 additions & 0 deletions src/core/public/http/types.ts
View file
Original file line number Diff line number Diff line change
@@ -283,6 +283,11 @@ export interface HttpFetchOptions extends HttpRequestInit {
withLongNumeralsSupport?: boolean;

prependOptions?: PrependOptions;

/**
*
*/
pureFetch?: boolean;
}

/**