Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Cross-Cluster-Search] Add Cross Cluster Search Functionality #9566

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Mar 18, 2025

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@LDrago27 LDrago27 changed the title [Cross-Cluster-Search] Add Cross Cluster Search Functionality [WIP][Cross-Cluster-Search] Add Cross Cluster Search Functionality Mar 18, 2025
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 53.22581% with 29 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (29f05d7) to head (40e81c1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...components/data_source_table/data_source_table.tsx 21.42% 9 Missing and 2 partials ⚠️
.../data_source_management/public/components/utils.ts 47.05% 6 Missing and 3 partials ⚠️
src/plugins/workspace/public/utils.ts 60.86% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9566      +/-   ##
==========================================
- Coverage   61.82%   61.80%   -0.03%     
==========================================
  Files        3825     3825              
  Lines       92040    92109      +69     
  Branches    14598    14615      +17     
==========================================
+ Hits        56902    56925      +23     
- Misses      31464    31503      +39     
- Partials     3674     3681       +7     
Flag Coverage Δ
Linux_1 ?
Linux_2 56.38% <ø> (ø)
Linux_4 28.84% <11.11%> (-0.02%) ⬇️
Windows_1 28.96% <47.91%> (+<0.01%) ⬆️
Windows_2 56.33% <ø> (ø)
Windows_3 39.42% <37.50%> (-0.01%) ⬇️
Windows_4 28.84% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -60,4 +60,5 @@ export enum DataSourceEngineType {
OpenSearchServerless = 'OpenSearch Serverless',
Elasticsearch = 'Elasticsearch',
NA = 'No Engine Type Available',
OpenSearchCrossCluster = 'OpensSearch(Cross-cluster search)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between OpenSearchCrossCluster and OpenSearch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants