-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cache): deprecate global disableDynamoDBCache and disableIncrementalCache #702
Conversation
🦋 Changeset detectedLatest commit: 6a5f350 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report
File Coverage
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of a breaking change, some people may rely on it (especially if they have a custom tag cache that they reuse across multiple apps).
Fully removing this in a future minor (with a warning) is probably more than enough, there is likely very very few people that rely on this ( if any at all )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
Thanks for the review |
@conico974 Actually, this might be a breaking change...
So maybe I should deprecate instead and add a changeset then we can remove later.
WDYT?