Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cache): deprecate global disableDynamoDBCache and disableIncrementalCache #702

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 17, 2025

@conico974 Actually, this might be a breaking change...
So maybe I should deprecate instead and add a changeset then we can remove later.
WDYT?

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 6a5f350

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.45% 1878 / 8006
🔵 Statements 23.45% 1878 / 8006
🔵 Functions 56.41% 110 / 195
🔵 Branches 70.72% 471 / 666
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 86.66% 83% 100% 86.66% 93-94, 155-157, 160-168, 216-227, 379-388, 423-431, 465-466
packages/open-next/src/overrides/tagCache/dynamodb-lite.ts 0% 0% 0% 0% 1-220
packages/open-next/src/overrides/tagCache/dynamodb.ts 0% 0% 0% 0% 1-166
packages/open-next/src/types/global.ts 0% 0% 0% 0%
Generated in workflow #894 for commit 6a5f350 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Jan 17, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@702

commit: 6a5f350

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of a breaking change, some people may rely on it (especially if they have a custom tag cache that they reuse across multiple apps).
Fully removing this in a future minor (with a warning) is probably more than enough, there is likely very very few people that rely on this ( if any at all )

@vicb vicb changed the title refactor: drop global disableDynamoDBCache and disableIncrementalCache refactor(cache): deprecate global disableDynamoDBCache and disableIncrementalCache Jan 17, 2025
@vicb vicb requested a review from conico974 January 17, 2025 20:33
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Jan 20, 2025

Thanks for the review

@vicb vicb merged commit 1981a47 into main Jan 20, 2025
3 checks passed
@vicb vicb deleted the rmglob branch January 20, 2025 07:13
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants