Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e for forbidden and unauthorized #669

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Dec 11, 2024

  • Add e2e test for forbidden and unauthorized (Next.js blog)
  • Next will set cache-control to s-maxage=31536000 on those routes, so i added 403 and 401 in fixHeadersForError() so they don't get cached

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: ae48e5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@669

commit: ae48e5c

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably wait a bit before merging this one, not sure what's the point of using forbidden or unauthorized on SSG route ( And they don't seem to work in middleware either )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants