Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Tools: Add Copy DSL Definition for Items and Things #3085

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 3, 2025

Resolve openhab/openhab-core#4509

This needs the changes to api.js made in #3021

image

Copy link

relativeci bot commented Mar 3, 2025

#2916 Bundle Size — 11.08MiB (+0.03%).

8f694b1(current) vs 6c88932 main#2915(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#2916
     Baseline
#2915
No change  Initial JS 2MiB 2MiB
No change  Initial CSS 577.34KiB 577.34KiB
Change  Cache Invalidation 18.12% 18.81%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2949(+0.03%) 2948
Regression  Duplicate Modules 150(+0.67%) 149
Change  Duplicate Code 1.72%(+0.58%) 1.71%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2916
     Baseline
#2915
Regression  JS 9.29MiB (+0.04%) 9.29MiB
No change  CSS 867.35KiB 867.35KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:copy-dsl-dev-toolsProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng
Copy link
Contributor Author

jimtng commented Mar 10, 2025

rebased

@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Mar 10, 2025
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. One minor suggestion:

@florian-h05 florian-h05 added this to the 5.0 milestone Mar 11, 2025
@florian-h05 florian-h05 merged commit ce53cc3 into openhab:main Mar 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to suggest file syntax for things and items to users
3 participants