Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget editor: Add note that properties are not evaluated in the editor #2007

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

florian-h05
Copy link
Contributor

No description provided.

@relativeci
Copy link

relativeci bot commented Aug 6, 2023

Job #1097: Bundle Size — 15.75MiB (~-0.01%).

a516164(current) vs bc8a71c main#1096(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1097
     Baseline
Job #1096
Initial JS 1.67MiB 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.95%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1097
     Baseline
Job #1096
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (~-0.01%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1097 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think it's a "cop out" though. I'm sure there could be a way to support expressions for the preview in the widget editor - though I haven't looked into it yet.

@ghys ghys added the main ui Main UI label Aug 6, 2023
@ghys ghys added this to the 4.1 milestone Aug 6, 2023
@ghys ghys merged commit 0d34818 into openhab:main Aug 6, 2023
4 checks passed
@florian-h05 florian-h05 deleted the widget-editor-eval-note branch August 6, 2023 20:04
@florian-h05
Copy link
Contributor Author

I think it's a "cop out" though. I'm sure there could be a way to support expressions for the preview in the widget editor

Yes, I had a look into it but I haven’t found a quick and simple solution — didn’t want to spend too much time.

@ghys
Copy link
Member

ghys commented Aug 8, 2023

Thinking back about my comment above, I don't want you to think you yourself "copped out"... it was a general remark about the problem and the ideal solution that should ultimately be provided, not about your contribution that you know I value.

@florian-h05
Copy link
Contributor Author

Everything fine on my side, no worries!

I'm not really satisfied myself either, that was the best thing to do quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants