Skip to content

Commit

Permalink
Fix unwanted model card back navigation (#2221)
Browse files Browse the repository at this point in the history
Fixes #2196.
Replaces #2211.

The double back navigation was caused by:

https://github.com/framework7io/framework7/blob/31f4c7065e8abe9b8b27f354de4e390a8cd584c0/src/core/utils/history.js#L56-L61

and `router.updateCurrentUrl()`, unlike the name implies, doesn't update
`router.url` for some reason (maybe a bug?).

-----

Signed-off-by: Yannick Schaus <[email protected]>
  • Loading branch information
ghys authored Dec 15, 2023
1 parent 813fb72 commit a5cce9a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions bundles/org.openhab.ui/web/src/pages/home.vue
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export default {
methods: {
onPageBeforeIn () {
this.$f7router.updateCurrentUrl('/' + this.currentTab)
this.$f7router.url = '/' + this.currentTab
this.overviewPageKey = this.$utils.id()
},
onPageAfterIn () {
Expand Down Expand Up @@ -198,6 +199,7 @@ export default {
switchTab (tab) {
this.currentTab = tab
this.$f7router.updateCurrentUrl('/' + this.currentTab)
this.$f7router.url = '/' + this.currentTab
},
tabVisible (tab) {
if (!this.tabsVisible) return false
Expand Down

0 comments on commit a5cce9a

Please sign in to comment.