Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name OID/TID strictly OID to avoid confusions #868

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

signedav
Copy link
Member

@signedav signedav commented Dec 13, 2023

  • Screenshots

@signedav signedav requested a review from domi4484 December 13, 2023 06:51
@signedav
Copy link
Member Author

@domi4484 Thanks. Hope it's the last one for a moment.


Since the user has to be able to edit those values, they are provided in the GUI.

Additionally to the [page implemented in the wizard](../../user_guide/import_workflow/#tid-oid-values) the configuration of the TIDs can be made on existing QGIS Projects.
Additionally to the [page implemented in the wizard](../../user_guide/import_workflow/#tid-oid-values) the configuration of the OIDs can be made on existing QGIS Projects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does those links work? They search for a chapter with that name using the - as a wildchar?

In that case the link should become ../../user_guide/import_workflow/#oid-values

In other places as well... maybe there is a pipeline action that can check those internal links?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are right, it should be #oid-values The - is representing a space.

Good idea to check the links in a pipeline. I wonder if there is something existing for that 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Adrien did something in the talking repo. Don't know if it can be used here

@signedav signedav merged commit b5808b2 into master Dec 13, 2023
6 checks passed
@signedav signedav deleted the oidtidnaming branch December 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants