Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore examples/ path when searching for coverage report #1937

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

mattwthompson
Copy link
Member

Debugging codecov/codecov-action#1568 - this unfortunately will work if the issue is either too many uploads from a single commit or the action trying to upload a broken notebook.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (c84b321) to head (b709be5).
Report is 1 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review September 13, 2024 16:13
@@ -171,4 +171,5 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
exclude: examples/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh ....

https://github.com/codecov/codecov-action/blob/180b964407756d9f1d1629a946b1bda4e5a76d46/action.yml#L32-L34

info - 2024-09-13 16:49:04,996 -- > /Users/runner/work/openff-toolkit/openff-toolkit/examples/deprecated/check_dataset_parameter_coverage/check_parameter_coverage.ipynb

@mattwthompson mattwthompson merged commit 382a3e8 into main Sep 13, 2024
18 checks passed
@mattwthompson mattwthompson deleted the ignore-examples-codecov branch September 13, 2024 17:58
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants