-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update experimental tag on examples, tests, experimental docs #1150
Conversation
c0c0264
to
7fa3c0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 70 70
Lines 6036 6036
=======================================
Hits 5637 5637
Misses 399 399 ☔ View full report in Codecov by Sentry. |
As this intersects with how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm self-assigning and approving since this is such a big blocker, and @Yoshanuikabundi has a hot deadline with the PTM notebook and then BeSMARTS documentation immediately after while we still have Trevor available. If there's a chance that this borks the interface with docs, then let's add a ticket to the backlog to check that once @Yoshanuikabundi has availability again.
Thank you! |
Description
With the 0.4.0 release, some methods are no longer "experimental" but many tests were not updated and
INTERCHANGE_EXPERIMENTAL=1
was unnecessarily set.This change also moves around an example that's no longer "experimental" into the root directory, which is needed for discovery in the docs automation: openforcefield/openff-docs#71
Checklist