Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental tag on examples, tests, experimental docs #1150

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

mattwthompson
Copy link
Member

Description

With the 0.4.0 release, some methods are no longer "experimental" but many tests were not updated and INTERCHANGE_EXPERIMENTAL=1 was unnecessarily set.

This change also moves around an example that's no longer "experimental" into the root directory, which is needed for discovery in the docs automation: openforcefield/openff-docs#71

Checklist

  • Add tests
  • Lint
  • Update docstrings

@mattwthompson mattwthompson force-pushed the move-experimental-examples branch from c0c0264 to 7fa3c0d Compare January 23, 2025 17:47
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (447743c) to head (166c45c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          70       70           
  Lines        6036     6036           
=======================================
  Hits         5637     5637           
  Misses        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwthompson mattwthompson marked this pull request as ready for review January 23, 2025 17:56
@mattwthompson
Copy link
Member Author

As this intersects with how openff-docs discovers examples, I think @Yoshanuikabundi is the best person to reason through these changes - particularly the example(s) moving around

@mattwthompson mattwthompson changed the title Update experimental tag on examples, tests Update experimental tag on examples, tests, experimental docs Feb 13, 2025
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm self-assigning and approving since this is such a big blocker, and @Yoshanuikabundi has a hot deadline with the PTM notebook and then BeSMARTS documentation immediately after while we still have Trevor available. If there's a chance that this borks the interface with docs, then let's add a ticket to the backlog to check that once @Yoshanuikabundi has availability again.

@mattwthompson
Copy link
Member Author

Thank you!

@mattwthompson mattwthompson merged commit 7a45c6b into main Feb 13, 2025
16 checks passed
@mattwthompson mattwthompson deleted the move-experimental-examples branch February 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants