-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Multi-Namespace support #64
Conversation
@LucasRoesler Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitishkumar71 there are a few small language changes that I think make the errors a little more consistent with the other tests or improve the readability slightly.
There is also one slightly larger request to allow the default namespace to be configurable as well.
But it otherwise looks great 👍
tests/deploy_test.go
Outdated
@@ -121,6 +123,30 @@ func Test_Deploy_WithAnnotations(t *testing.T) { | |||
} | |||
} | |||
|
|||
func Test_DeploymentNamespaces(t *testing.T) { | |||
defaultNamespace := "openfaas-fn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to an ENV config as well: CERTIFIER_DEFAULT_NAMESPACE
we can set this to openfaas-fn
if it is empty This will allow us to run it against non-standard installations as well, so that we have
expectedNamespaces := append(config.Namespaces, config.DefaultNamespace)
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Nitishkumar Singh <[email protected]> Apply suggestions from code review Co-authored-by: Lucas Roesler <[email protected]> Apply Reviews Signed-off-by: Nitishkumar Singh <[email protected]>
ec81487
to
2b0bb37
Compare
@LucasRoesler Thank you for the review. I have made all the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great 🚀
Signed-off-by: Nitishkumar Singh [email protected]
Closes #63
Testing Steps
kind create cluster --name fass-pv-test
arkade install openfaas --basic-auth=false --clusterrole
kubectl port-forward -n openfaas svc/gateway 8080:8080 &
export CERTIFIER_NAMESPACES=staging-fn,dev
make test-kubernetes