Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi namespaces Support #62

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Multi namespaces Support #62

merged 1 commit into from
Apr 2, 2021

Conversation

nitishkumar71
Copy link
Member

It will help in closing #61

@derek
Copy link

derek bot commented Mar 27, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Mar 27, 2021
@nitishkumar71 nitishkumar71 force-pushed the multi_namespaces_support branch from d5d1015 to bf8ba3a Compare March 27, 2021 18:40
@derek derek bot removed the no-dco label Mar 27, 2021
LucasRoesler
LucasRoesler reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry it took so long to get to this. Work has been a bit crazy this week.

Overall, it looks good, we can make one tiny improvement though

I am off from work this week, so I will definitely respond much more quickly.

tests/main_test.go Show resolved Hide resolved
@nitishkumar71 nitishkumar71 force-pushed the multi_namespaces_support branch from bf8ba3a to 090c0f3 Compare April 2, 2021 10:29
@nitishkumar71
Multi Namespace Test Support
b0b889f 
Signed-off-by: Nitishkumar Singh <[email protected]>

updates for multi-namespaces

Signed-off-by: Nitishkumar Singh <[email protected]>

Replace Space from Namespaces Env variables

Signed-off-by: Nitishkumar Singh <[email protected]>

Reomve space from namespaces

Signed-off-by: Nitishkumar Singh <[email protected]>
@nitishkumar71 nitishkumar71 force-pushed the multi_namespaces_support branch from 090c0f3 to b0b889f Compare April 2, 2021 10:34
@nitishkumar71
Copy link
Member Author

nitishkumar71 commented Apr 2, 2021 •
edited
Loading

I'm sorry it took so long to get to this. Work has been a bit crazy this week.

Overall, it looks good, we can make one tiny improvement though

I am off from work this week, so I will definitely respond much more quickly.

I can totally relate with this for me.

@nitishkumar71 nitishkumar71 changed the title [WIP] Multi namespaces Support Multi namespaces Support Apr 2, 2021
@LucasRoesler LucasRoesler merged commit 9d1270d into openfaas:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasRoesler LucasRoesler LucasRoesler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitishkumar71 @LucasRoesler