Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaxonomyControlsTest #5178

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fix TaxonomyControlsTest #5178

merged 3 commits into from
Jan 23, 2025

Conversation

PenghaiZhang
Copy link
Contributor

Checklist
Description of change

I believe the flakyness in this test is due to Selenium not being able to click the right element in smaller browser window. So the potential fix is to use JS to do the click.

@PenghaiZhang
Copy link
Contributor Author

The first run was happy.

@PenghaiZhang
Copy link
Contributor Author

HI @edalex-ian this PR is ready for review.

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can see the failing tests are those we've fixed elsewhere.

Once we get this merged in, perhaps we should get our other fixes across here to GitHub.

@PenghaiZhang PenghaiZhang merged commit 687feb8 into develop Jan 23, 2025
3 of 6 checks passed
@PenghaiZhang PenghaiZhang deleted the fix/taxonomy-controls-test branch January 23, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants