#35 - dry run and scrub images from description #36
Conversation
|
Due to the nature of this side project, I plan to move fairly quick on this PR and merge this evening unless folks have any concerns with the changes. |
...nLTI/src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/Fixer.java
Outdated
Show resolved
Hide resolved
...nLTI/src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/Fixer.java
Outdated
Show resolved
Hide resolved
...nLTI/src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/Fixer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/FixerUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/FixerUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Travis CI is flagging 100 build errors, all related to javax.jws.*.
Would is be possible to fix these before merging?
https://travis-ci.com/github/openequella/openEQUELLA-blackboard-integration/builds/176595380#L246-L661
…ration/blackboard/linkmigrationlti/Fixer.java Co-authored-by: Christian Murphy <[email protected]>
…ration/blackboard/linkmigrationlti/Fixer.java Co-authored-by: Christian Murphy <[email protected]>
…ration/blackboard/linkmigrationlti/Fixer.java Co-authored-by: Christian Murphy <[email protected]>
|
The SOAP WS are being removed in Blackboard, and this release is focused on just the migration B2. I'll update the build targets to only release that project for now. Ideally, the standard B2 and WS won't have to be revised again, and adopters will switch over to the standard LTI flows. |
|
Cleaned up the regex's and string replacements for a cleaner, more robust solution (Thanks @ChristianMurphy ). |
There was a problem hiding this comment.
Looks good, thanks @cbeach47!
A couple small simplifications may be possible, but the approach as a whole looks solid 👍
...src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/FixerUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apereo/openequella/integration/blackboard/linkmigrationlti/FixerUtils.java
Show resolved
Hide resolved
Supports a 'dry run' ability and scrubs images embedded in various html tags in the description.
Also upgraded Bb libraries to 3800.15.0 , which required upgrading Gradle and nebula.lint.