Report reconciliation errors as part of the component' status (pt1)

[lburgazzoli]

Description

This commit introduces some enhancement to what and how components are
reporting theirs status by:

• Includes a Ready top-level condition which summarizes more detailed
  conditions
• Includes a ProvisioningSucceeded condition that reports any
  provisioning error, i.e. a deployment fails to be provisioned because
  of any invalid fields, some pre-requisites are not met

apiVersion: components.platform.opendatahub.io/v1alpha1
kind: ModelRegistry
metadata:
  name: default-modelregistry
spec:
  registriesNamespace: odh-model-registries
status:
  conditions:
  - lastTransitionTime: "2025-02-03T13:10:32Z"
    message: 0/1 deployments ready
    reason: DeploymentsNotReady
    status: "False"
    type: Ready
  - lastTransitionTime: "2025-02-03T12:55:45Z"
    status: "True"
    type: ProvisioningSucceeded
  - lastTransitionTime: "2025-02-03T13:10:32Z"
    message: 0/1 deployments ready
    reason: DeploymentsNotReady
    status: "False"
    type: DeploymentsAvailable
  - lastTransitionTime: "2025-02-03T12:55:32Z"
    status: "True"
    type: ServerlessAvailable

Note

in the case we want a condition to be set to False, but that should not affect the top level condition, it is possible to set the severity field as Info (the default is Error and it is being represented by an empty value):

  - lastTransitionTime: "2025-02-03T13:10:42Z"
    reason: FooReasin
    severity: Info
    status: "True"
    type: Foo

If needed, additional conditions can be added by individual component or
services:

_, err := reconciler.ReconcilerFor(mgr, &componentApi.ModelRegistry{}).
    // ...
    WithConditions(
	status.ConditionDeploymentsAvailable,
	status.ConditionServerlessAvailable).
    Build(ctx)

To help managing conditions, a conditions.Manager type has been
inrtoduced, largely inspired by Knative's conditions set code [1], but
improved to handle our specific use cases.

[1] https://github.com/knative/pkg/blob/main/apis/condition_set.go

https://issues.redhat.com/browse/RHOAIENG-18216

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lburgazzoli. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 44.80000% with 276 lines in your changes missing coverage. Please review.

Project coverage is 23.51%. Comparing base (2c5e52a) to head (6480990).

Files with missing lines	Patch %	Lines
pkg/controller/conditions/conditions.go	67.59%	50 Missing and 8 partials ⚠️
...ers/components/kserve/kserve_controller_actions.go	0.00%	44 Missing ⚠️
.../modelregistry/modelregistry_controller_actions.go	0.00%	26 Missing ⚠️
...pelines/datasciencepipelines_controller_actions.go	0.00%	24 Missing ⚠️
pkg/controller/reconciler/reconciler.go	79.56%	16 Missing and 3 partials ⚠️
controllers/components/kueue/kueue_controller.go	0.00%	15 Missing ⚠️
...status/deployments/action_deployments_available.go	50.00%	13 Missing and 1 partial ⚠️
...llers/components/kueue/kueue_controller_actions.go	0.00%	7 Missing ⚠️
...llers/services/monitoring/monitoring_controller.go	0.00%	7 Missing ⚠️
pkg/controller/predicates/dependent/dependent.go	0.00%	7 Missing ⚠️
... and 16 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
+ Coverage   22.15%   23.51%   +1.35%     
==========================================
  Files         165      166       +1     
  Lines       11302    11552     +250     
==========================================
+ Hits         2504     2716     +212     
- Misses       8542     8570      +28     
- Partials      256      266      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.