-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Disallow enabling components for unsupported architectures for single arch cluster #1641
base: main
Are you sure you want to change the base?
Conversation
This commit adds changes to determine if cluster nodes have ibm power architecture
This commit adds changes to allow components that support ibm power arch to be deployed
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@VaishnaviHire: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
return fmt.Errorf("unable to determine architecture %v", err) | ||
} | ||
if isPowerArch { | ||
nc.Status = status.ReconcileCompleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this Status should be True or False , not reason?
Description
This is an interim PR till we have support for mixed-arch as part of #1624
This PR introduces following changes:
How Has This Been Tested?
Screenshot or short clip
Merge criteria