Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Disallow enabling components for unsupported architectures for single arch cluster #1641

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Feb 10, 2025

Description

This is an interim PR till we have support for mixed-arch as part of #1624

This PR introduces following changes:

  1. Check if cluster is ibm power cluster
  2. Deploy only Dashboard and Kserve
  3. Introduce UnsupportedArchitecture Status for components that do not support multi-arch.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This commit adds changes to determine if cluster nodes have ibm power architecture
This commit adds changes to allow components that support ibm power arch to be deployed
Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 10, 2025

@VaishnaviHire: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e 16df781 link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

return fmt.Errorf("unable to determine architecture %v", err)
}
if isPowerArch {
nc.Status = status.ReconcileCompleted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this Status should be True or False , not reason?

@VaishnaviHire VaishnaviHire changed the title [WIP] Disallow enabling components for unsupported architectures [WIP] Disallow enabling components for unsupported architectures for single arch cluster Feb 11, 2025
@VaishnaviHire VaishnaviHire marked this pull request as draft February 13, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants