NO-ISSUE: chore(ci): fix expected image names in params.env check #981
Conversation
With recent 2025a image version introduced, we fixed some image build names annotations and these need to be reflected in this check now. For older images, the fixes weren't applied as they weren't rebuild, so no fix is done for these N-1 image version checks.
|
Thank you Jan for that fix! |
|
/lgtm |
|
Thank you for your reviews guys! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/images |
|
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you for this fix @jstourac ! I had fixed the annotations are part of my Dockerfile refactor - but just totally overlooked the fact they were being tested against now... apologies for my oversight! |
|
/override "validation-of-params-env " this PR only fixes the image build name annotations - and we can see from the failed job that nothing is failing the name check now. other fixes will be investigated and dealt with in separate PR! |
|
@andyatmiami: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "validation-of-params-env" |
|
@andyatmiami: Overrode contexts on behalf of andyatmiami: validation-of-params-env In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1f9b227
into
opendatahub-io:main
With recent 2025a image version introduced, we fixed some image build names annotations and these need to be reflected in this check now.
For older images, the fixes weren't applied as they weren't rebuild, so no fix is done for these N-1 image version checks.
How Has This Been Tested?
Note: there are still failures in this script due to the image size changes. These will be investigated first and then fixed with a followup PR eventually.
Merge criteria: