Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudacodec - VideoWriter h265 QuickTime compatibility #3882

Conversation

cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Feb 9, 2025

Apple QuickTime is unable to play h265 files stored in containers created using hev1 fourcc and requires hvc1 (see forum thread). Because hvc1 (sps/pps in the header) also works perfectly in vlc this PR changes the default fourcc for h265 from hev1 to hvc1.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review February 10, 2025 07:41
@asmorkalov asmorkalov self-assigned this Feb 10, 2025
@asmorkalov
Copy link
Contributor

Tested manually with GF 1080.

@asmorkalov asmorkalov merged commit ce3c668 into opencv:4.x Feb 10, 2025
12 checks passed
@asmorkalov asmorkalov mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants