Replace deprecated uses: actions/upload-artifact@v3 with v4.

[asmorkalov]

Github actions warning example:

macOS-ARM64 / BuildAndTest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[fengyuentau]

I cannot view the log in https://github.com/opencv/ci-gha-workflow/actions/runs/8534602216/job/23379325500?pr=167. Is it relevant to the warnings? Also tried downloading the loag archive and it was empty.

[asmorkalov]

The same on my side. Looks like some GHA bug. I use raw logs option for such case.

[fengyuentau]

2024-04-03T07:05:58.8270293Z Job defined at: opencv/ci-gha-workflow/.github/workflows/OCV-PR-3.4-U14.yaml@refs/pull/167/merge

...

##[command]/usr/bin/docker exec  925a76b7a9ac7bc8802522ec856affff405e035efb91532f09ff058f7c7ea94b sh -c "cat /etc/*release | grep ^ID"
2024-04-03T07:53:14.2312052Z /__e/node20/bin/node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
2024-04-03T07:53:14.2316924Z /__e/node20/bin/node: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /__e/node20/bin/node)
2024-04-03T07:53:14.2322350Z /__e/node20/bin/node: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /__e/node20/bin/node)
2024-04-03T07:53:14.2327955Z /__e/node20/bin/node: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /__e/node20/bin/node)
2024-04-03T07:53:14.2334209Z /__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
2024-04-03T07:53:14.2339339Z /__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

Looks like node requires newer version of libstdc++, thats why some checks (most probably Ubuntu 14) did not pass in stage "Save Unit Test Results".

[asmorkalov]

Ok, let's revert changes for Ubuntu 14.04 cases then.

[fengyuentau]

Most of the failed checks were getting networking problem:

2024-04-03T13:29:29.4103931Z ##[error]Failed to CreateArtifact: Unable to make request: ECONNRESET
If you are using self-hosted runners, please make sure your runner has access to all GitHub endpoints: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#communication-between-self-hosted-runners-and-github