Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI Test Suite for open_data_pvnet #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SophiaLi20
Copy link

This PR cleans up and improves the test suite for the open_data_pvnet CLI. The goal is to make the tests more readable, maintainable, and robust, while also covering a few missing edge cases.
What’s Changed?

  • Refactored Repetitive Code
  • Made Tests Easier to Read
  • Covered More Edge Cases
  • Better Mocks, More Reliable Tests

Why this change matter?
This makes the test suite cleaner, easier to maintain, and ready for future updates. It also ensures we don’t miss edge cases that could cause unexpected failures.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • No breaking changes introduced
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant