Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start sampler code for met office #59

Closed
wants to merge 1 commit into from
Closed

Conversation

jcamier
Copy link
Collaborator

@jcamier jcamier commented Feb 8, 2025

Pull Request

Issue #33

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    -[x] I have checked my code and corrected any misspellings

@jcamier jcamier marked this pull request as draft February 8, 2025 01:35
Copy link
Contributor

@siddharth7113 siddharth7113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good, apart from the import statment, and if the test pass this is good to go.

Returns:
Dictionary mapping internal dataset variables to NWPSampleKey formatted names.
"""
from open_data_pvnet.utils.data_downloader import open_zarr_group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put this import at the starting of the file.

@jcamier jcamier closed this Feb 15, 2025
@jcamier
Copy link
Collaborator Author

jcamier commented Feb 15, 2025

This was doing redundant functionality of ocf-data-sampler. So closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants