Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli/pvlive #54

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

alirashidAR
Copy link
Contributor

Pull Request

Description

Adding cli functionality for pvlive along with uploading it to HF(tentative)

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jcamier
Copy link
Collaborator

jcamier commented Feb 6, 2025

@alirashidAR started looking at this PR and I have some changes on my end as well and we might have some merge conflicts, lol. No worries. I am not done with mine yet but will include you on my PR when it is done and we can go from there.

@alirashidAR
Copy link
Contributor Author

Sure, sorry for the late reply I will start working on the s3 upload functionalities parallelly

@alirashidAR
Copy link
Contributor Author

@jcamier should I work on the s3 upload functionality or continue with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants