Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect data #36

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Collect data #36

merged 4 commits into from
Jan 15, 2025

Conversation

alirashidAR
Copy link
Contributor

Pull Request #2

Description

Collected data from the PV-Live API and stored it as a NetCDF file

Sample Data:
image

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@alirashidAR
Copy link
Contributor Author

@peterdudfield, I hope this data meets your requirements.

Please let me know if there are any additional changes or further adjustments needed.

@peterdudfield
Copy link
Contributor

Looks great, I wonder if we dont add it to the code, but if you send me the file, then I can put it up on s3. You might be able to just drop the file in this PR as a comment? What do you think?

@alirashidAR
Copy link
Contributor Author

Yes I think it would be better , reduces redundancy. I'll make the changes shortly.

@alirashidAR
Copy link
Contributor Author

alirashidAR commented Jan 15, 2025

@peterdudfield
The comments don't support netCDF files, so I uploaded the data to my Google Drive. Here's the link:

https://drive.google.com/drive/folders/14n-wR68sBKLwR_psb4Y7gcdLzjXBQTRL?usp=sharing

@peterdudfield
Copy link
Contributor

Thanks, ive uploaded it here s3://ocf-open-data-pvnet/data/uk/pvlive/v0/target_data.nc

@peterdudfield
Copy link
Contributor

Could you add back in the script you used?

@alirashidAR
Copy link
Contributor Author

alirashidAR commented Jan 15, 2025

Could you add back in the script you used?

b76f785

Oh I reverted back two commits ,
I'll add it back .

@peterdudfield
Copy link
Contributor

Im happy to merge, if you are?

@alirashidAR
Copy link
Contributor Author

yes , thank you!

@peterdudfield peterdudfield merged commit 47dff6b into openclimatefix:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants