Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open Data Pvnet #713

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Add Open Data Pvnet #713

merged 5 commits into from
Dec 9, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 8, 2024 •
edited
Loading

Pull Request

Description

Add

  • s3 public bucket
  • IAM user group that can write to the bucket

Helps with openclimatefix/open-data-pvnet#11

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc December 9, 2024 12:38
@peterdudfield peterdudfield marked this pull request as ready for review December 9, 2024 12:39
@peterdudfield peterdudfield merged commit 9425a67 into main Dec 9, 2024
5 checks passed
@peterdudfield peterdudfield deleted the s3-open-data-pvnet branch December 9, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc