Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFS Data Support in ocf-data-sampler #199

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

siddharth7113
Copy link
Contributor

@siddharth7113 siddharth7113 commented Mar 3, 2025

Description

This PR adds support for GFS (Global Forecast System) data in ocf-data-sampler. Previously, GFS was not recognized as a valid provider, causing a ValueError: Unknown provider: gfs. This change introduces:

  • A new GFS data loader (gfs.py) under ocf_data_sampler/load/nwp/providers/.
  • Modifications to nwp.py to recognize "gfs" as a valid provider and use open_gfs.
  • Ensured compatibility with the existing structure of ocf-data-sampler.

Fixes: #188

Checklist

@Sukh-P
Copy link
Member

Sukh-P commented Mar 5, 2025

Thanks for making a start on this @siddharth7113 think it just needs a few small tweaks and then would be good to go!

@siddharth7113
Copy link
Contributor Author

Thanks for making a start on this @siddharth7113 think it just needs a few small tweaks and then would be good to go!

Thank you for taking time out to review @Sukh-P , I have made the necessary changes.

@Sukh-P
Copy link
Member

Sukh-P commented Mar 5, 2025

Great work adding this in @siddharth7113, thanks!

@Sukh-P Sukh-P merged commit f262bfd into openclimatefix:main Mar 5, 2025
@siddharth7113 siddharth7113 deleted the gfs-constants branch March 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants