-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi-react-query): Introduce createQuery #1858
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3bfc764 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @zsugabubus! Thanks a lot for willing to contribute, there are really interesting ideas here! As stated in the CONTRIBUTING.md we require new features are discussed first in an issue so you do no one waste time writing code that might not be accepted. Regarding your Pull request, there are three related issues:
Aswell, it is always good to avoid mixing new features in the same PR (when possible): Pass down signal to fetch function this way
|
050894e
to
a6eff7d
Compare
Removed unrelated features and (seeing the other issues) I renamed the function to |
Hi @zsugabubus, I think this is ready to merge. We just need the documentation for the new |
a6eff7d
to
3bfc764
Compare
@kerwanp Added docs but I have to say I'm not a good writer. |
Changes
Fixes #1807. Instead of adding a dedicated
useQueries
function I would like propose a general query builder solution, this way not onlyuseQueries
, but all similar functions are covered for free.Unfortunately, I could not resist and introduced two other (minor) changes on my way to the new feature. I'm happy to remove/split them. Please see changeset.How to Review
Checklist
docs/
updated