-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/torch load weights only warning #2301
base: main
Are you sure you want to change the base?
Fix/torch load weights only warning #2301
Conversation
Just to add to the documentation of this issue, the default for
(from https://pytorch.org/docs/2.4/generated/torch.load.html#torch-load) Related HuggingFace on Pickle |
Thank you for the addition! |
Hey @Ultr4Dev thanks for creating this PR. Do you plan to move it forward? 🙏 |
This pull request updates the load_model function of the Whisper ASR model, enhancing documentation and incorporating a weights_only parameter for more flexible model weight handling. The update addresses a FutureWarning regarding the use of torch.load with weights_only=False, recommending a safer loading method to mitigate security risks associated with loading untrusted model data. This change is designed to improve both the functionality and security of the model loading process.
Relevant info Untrusted models