Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #2281

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Main #2281

wants to merge 3 commits into from

Conversation

ashishpatel26
Copy link

@ashishpatel26 ashishpatel26 commented Jul 29, 2024

Summary

This pull request addresses several issues to improve the robustness and documentation of the audio.py file.

Changes

  1. Error Handling:

    • Added a try-except block in the log_mel_spectrogram function to catch and print errors.
  2. Improved Documentation:

    • Enhanced docstrings for the load_audio, pad_or_trim, mel_filters, and log_mel_spectrogram functions for better clarity.

Related Issues

Testing

All existing tests pass. Additional tests can be added to verify the new error handling.

- Added try-except block in log_mel_spectrogram to catch and print errors.
- Enhanced docstrings for load_audio, pad_or_trim, mel_filters, and log_mel_spectrogram functions.
- Implemented per-token confidence tracking in GreedyDecoder and BeamSearchDecoder.
- Updated DecodingResult to include tokens_probs.
- Enhanced token update methods to calculate and store token probabilities.
- Improved finalization methods to handle token probabilities.
- Modified DecodingTask to manage per-token confidence during the decoding process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant