Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .pre-commit-config.yaml #1528

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Add .pre-commit-config.yaml #1528

merged 3 commits into from
Sep 18, 2023

Conversation

kimdwkimdw
Copy link
Contributor

@kimdwkimdw kimdwkimdw commented Jul 17, 2023 •
edited
Loading

I've created a pull request to run a pre-commit GitHub action explicitly for repetitive linter tasks.

  • Replace black, isort, flake8 with pre-commit ( .pre-commit-config.yaml )
  • After checking coverage for all files using the command below, I've reduced the number of flake8's ignore from E203,W503,W504,E501,E731,E741 to four: E203,E501,W503,W504. 
     pre-commit run -a
  • I've tested in Add .pre-commit-config.yaml kimdwkimdw/whisper#1

@jongwook jongwook merged commit 8b330df into openai:main Sep 18, 2023
8 checks passed
@kimdwkimdw kimdwkimdw deleted the feature/add_pre-commit branch September 22, 2023 06:12
abyesilyurt pushed a commit to abyesilyurt/whisper that referenced this pull request Nov 13, 2023
@kimdwkimdw @jongwook @abyesilyurt
Add .pre-commit-config.yaml (openai#1528)
45d5c0e 
* Add .pre-commit-config.yaml

Co-authored-by: arthur <[email protected]>

* flake8 E741

---------

Co-authored-by: Jong Wook Kim <[email protected]>
yaomingamd pushed a commit to ROCm/whisper that referenced this pull request Nov 27, 2023
@kimdwkimdw @jongwook @yaomingamd
Add .pre-commit-config.yaml (openai#1528)
cfc858f 
* Add .pre-commit-config.yaml

Co-authored-by: arthur <[email protected]>

* flake8 E741

---------

Co-authored-by: Jong Wook Kim <[email protected]>
RemedialGenius101
RemedialGenius101 approved these changes Apr 13, 2024
View reviewed changes
whisper/timing.py
@@ -202,7 +202,7 @@ def find_alignment(
hook.remove()

# heads * tokens * frames
weights = torch.stack([QKs[l][h] for l, h in model.alignment_heads.indices().T])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [x]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemedialGenius101 RemedialGenius101 RemedialGenius101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdwkimdw @RemedialGenius101 @jongwook