Support Recursive Nodes in OpenAI Agents Draw Graph Visualization Extension #387
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i realized the extension is not able to graph when an agent is recursive or has some path back to it. - intergrated way of keeping track of visited nodes(handoffs) - graph the new nodes with the return arrows
|
Awesome. |
rm-openai
requested changes
Apr 3, 2025
| if visited is None: | ||
| visited = set() | ||
|
|
||
| if agent.name in visited: |
There was a problem hiding this comment.
multiple agents can share the same name, perhaps we can use the object instead?
| if not parent: | ||
| parts.append( | ||
| f'"{agent.name}" [label="{agent.name}", shape=box, style=filled, ' | ||
| "fillcolor=lightyellow, width=1.5, height=0.8];" | ||
| '"__start__" [label="__start__", shape=ellipse, style=filled, ' |
There was a problem hiding this comment.
I know this isn't directly related to the PR, but it would be cool if we could first build a graph representation, and then second turn that into a visualization. That way, you could have different graph formats (graphviz, mermaid etc), and share code between them,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the OpenAI Agents Graph extension by adding support for recursive nodes and cycles. Currently, the extension does not properly graph an agent when it is recursive or has a path that loops back to itself.
Changes Introduced:
This change improves the visualization of agents with cyclic or recursive behaviors, making the graph more accurate and comprehensive.