Request index: filter by source/target project #17408
Merged
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ncounter
commented
Feb 20, 2025
•
ncounter
commented
ncounter
force-pushed
the
request-index-filter-project
branch
2 times, most recently
from
2c7306c to
778103d
Compare
ncounter
force-pushed
the
request-index-filter-project
branch
3 times, most recently
from
6539300 to
84d54fb
Compare
krauselukas
added
the
review-app
|
Review app will appear here: http://obs-reviewlab.opensuse.org/ncounter-request-index-filter-project |
ncounter
force-pushed
the
request-index-filter-project
branch
from
84d54fb to
d6ecd90
Compare
ncounter
force-pushed
the
request-index-filter-project
branch
from
d6ecd90 to
7c2a744
Compare
danidoni
approved these changes
Feb 21, 2025
hennevogel
reviewed
Feb 21, 2025
Comment on lines
+41
to
+42
| scope :from_project_names, ->(project_names) { where(bs_request_actions: { source_project: project_names }) } | ||
| scope :to_project_names, ->(project_names) { where(bs_request_actions: { target_project: project_names }) } |
There was a problem hiding this comment.
What's the difference to the scope above?
There was a problem hiding this comment.
The ones above take a single string and they query for a single partial match aka 'LIKE %project%'. The new ones take an array of complete project names and they query for perfect matches aka 'IN [project1, project2]'.
Combining both is possible but feels like overcomplicating them because it should always consider both matching criteria.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.