-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test (e2e): Add new e2e testRigor tests #2200
test (e2e): Add new e2e testRigor tests #2200
Conversation
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
c4a1d76
to
4ae7364
Compare
@amandassa are you able to fix the conflict file? |
561fc28
to
2f8deff
Compare
Hello @IOhacker, can you review the PR please? |
@amandassa I think that this PR requires a suscription for a paid service? isn't ? |
2f8deff
to
84c00da
Compare
@IOhacker For this integration I used a testRigor OpenSource suite. The testRigor OpenSource option provides a free suite and it is free forever. You can get more info at testRigor Website |
Which is the open source github repository?
Where can we review the license?
I see some variables that must be enable. Which are the steps to get the
values and set them on the github account.
How to set the values for a developer? Or how to skip this testing?
Is there any other similar alternatives?
Do you have a video about the changes/benefits of this PR?
Regards
Regards
Victor
El lun., 17 de febrero de 2025 8:28 a. m., Amanda ***@***.***>
escribió:
… @IOhacker <https://github.com/IOhacker> For this integration I used a
testRigor OpenSource suite. The testRigor OpenSource option provides a free
suite and it is free forever. You can get more info at testRigor Website
<https://testrigor.com/>
—
Reply to this email directly, view it on GitHub
<#2200 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAQYKD35PFIQSMKNI4D2QHWXLAVCNFSM6AAAAABSDJ2JOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTGI4DQNJVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: amandassa]*amandassa* left a comment (openMF/web-app#2200)
<#2200 (comment)>
@IOhacker <https://github.com/IOhacker> For this integration I used a
testRigor OpenSource suite. The testRigor OpenSource option provides a free
suite and it is free forever. You can get more info at testRigor Website
<https://testrigor.com/>
—
Reply to this email directly, view it on GitHub
<#2200 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAQYKD35PFIQSMKNI4D2QHWXLAVCNFSM6AAAAABSDJ2JOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTGI4DQNJVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Q: Which is the open source github repository? Where can we review the license? A: testRigor OpenSource is a free testRigor account option that allows testing open source projects using testRigor service for free. Q: I see some variables that must be enable. Which are the steps to get the values and set them on the github account. How to set the values for a developer? A: The variables CI/CD Token and test suite ID can be found at the test suite CI integration page and test suite initial page. For this PR, I created a free testRigor account and suite for Mifos and linked the free suite to the bash script that runs the testRigor CLI tool on the workflow. This means that no further configuration is needed, since the workflow is already triggering a testRigor run within the free suite I created. In addition to the integration, I included a README.md file with instructions for integration for Mifos developers. Following those instructions it is possible to test new features locally with testRigor before they are deployed. It is also possible for a developer to create their own testRigor account and test locally on that. It is also possible to change the variables and link the execution to a test suite other than the one I created for Mifos. Q: Or how to skip this testing? A: This testing step consists of reliable End-to-end testing of the most crucial functionalities in Mifos. Currently only the Mifos login page is being tested. Including these tests to the CI would drastically improve reliability and bug tracking Q: Is there any other similar alternatives? Do you have a video about the changes/benefits of this PR? A: One of the reasons for using testRigor instead of other testing alternatives like Cypress is the improved maintenability. Since the tests are written in plain english, anyone can create and update tests. That can be useful for an open source project like Mifos. I noticed you have a directory for cypress integration tests, but no tests were added in the last 3 years. |
Hello @amandassa, I have look for the license and terms of use and I have only found these: https://testrigor.com/terms-of-use/ I was unable to find any github repository for libraries or source code of RigorTest. In my opinion I am not fully convinced to link a commercial software testing platform (even with a Free account). I have not found how this platform is supporting the Open Source communities. I reviewed the scripts included in the PR and they implement the functionality provided by RigorTest Platform which could lead to a vendor lock-in. |
84c00da
to
1b756ab
Compare
Hi @IOhacker, there is no vendor lock-in. It is plain English plain text, meaning that any modern automation tool will execute those. testRigor is contributing to open source community by providing free infrastructure to run tests to open source projects. Would you rather have little-to no end-to-end tests or accept free tests? |
@amandassa it is a vendor lock in when the plain English can be executed only in the RigorTest. I will take a look how they behave using Autonomiq, Testim or TestSigma... or Selenium. That is my technical perspective. On the other hand @edcable @DavidH-1 could you please check how this integration (Rigor Test Platform) can benefit the Mifos Community. |
1b756ab
to
9bc32e4
Compare
Thanks @IOhacker for highlighting. In some ways I’m not worried by plain text definition that has advantages just like plan text in Cucumber/gherkin I guess my concerns are two fold: |
@DavidH-1 Thanks for reviewing. |
9bc32e4
to
0c2fd32
Compare
E2e cover of the main functionalities CI added to build.yml
0c2fd32
to
fb19028
Compare
Description
Added e2e tests for the main web-app functionalities.
Dependencies
Related issues and discussion
#2199
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md
.