Add direct download of proforma zip #2834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoehn
force-pushed
the
1521-allow-downloading-proforma-zip-files
branch
from
4a21c2d to
31e7826
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 211 211
Lines 6751 6755 +4
=======================================
+ Hits 4701 4704 +3
- Misses 2050 2051 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MrSerth
reviewed
Mar 20, 2025
| @@ -37,6 +37,8 @@ de: | |||
| download_file_tree: | |||
| file_root: Erstellte Dateien | |||
| gone: Die angeforderte Datei konnte nicht abgerufen werden. Erstellte Dateien werden nur kurzzeitig vorgehalten und dann gelöscht. Bitte führen Sie den Code erneut aus und versuchen Sie dann wieder den Download der Datei. | |||
| download_proforma: | |||
| label: Download Proforma Zip | |||
There was a problem hiding this comment.
Based on our wording in CodeHarbor, I would recommend using ZIP with capital letters.
Suggested change
| label: Download Proforma Zip | |
| label: Download Proforma ZIP |
In CodeHarbor, we also used the term "ProformaXML". However, this might be too long:
Alternatively, we dropped "ProformaXML" completely 🙈:
Long story short: I would, at least, capitalize ZIP. On everything else, I am undecided.
| @@ -37,6 +37,8 @@ en: | |||
| download_file_tree: | |||
| file_root: Generated Files | |||
| gone: The requested file could not be retrieved. Generated files are only held for a short time and are then deleted. Please run the code again and then try downloading the file a second time. | |||
| download_proforma: | |||
| label: Download Proforma Zip | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds download part for #1521