Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java metric guidelines link #6123

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

nchen000
Copy link
Contributor

Fix metric guidelines link under Java API docs so it would stop points to http://localhost:1313/docs/specs/semconv/general/metrics/#general-guidelines.

@nchen000 nchen000 requested a review from a team as a code owner January 30, 2025 15:32
Copy link

linux-foundation-easycla bot commented Jan 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: opentelemetrybot / name: OpenTelemetry Bot (506d736)
  • ✅ login: cartermp / name: Phillip Carter (e49b498)
  • ✅ login: nchen000 / name: Nan Chen (2d27eae)

@opentelemetrybot opentelemetrybot requested review from a team January 30, 2025 15:33
@chalin
Copy link
Contributor

chalin commented Jan 30, 2025

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13056698826

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @nchen000, and thanks for the fix.

@open-telemetry/docs-approvers - I'll follow up with:

@chalin
Copy link
Contributor

chalin commented Jan 30, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13056777158

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin chalin enabled auto-merge January 30, 2025 16:48
nchen000 and others added 2 commits January 30, 2025 13:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@chalin chalin force-pushed the java-metric-guidelines-link branch from f03c0b7 to 506d736 Compare January 30, 2025 18:25
@chalin chalin added this pull request to the merge queue Jan 30, 2025
Merged via the queue into open-telemetry:main with commit 90502fe Jan 30, 2025
17 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey: https://forms.gle/WV58koUBGSG9HBY66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants