Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary: add terms from style guide, and some rework #6074

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Glossary: add terms from style guide, and some rework #6074

merged 6 commits into from
Jan 24, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 24, 2025 •
edited
Loading

  • Related / in prep for Move the Glossary to the top-level of docs #6068
  • Consolidates the "terms" in the style guide, by moving them into the glossary, and referring to the glossary. Moves spelling & capitalization recommendations along with them.
  • Copyedits and style (markdown) cleanup of the glossary and a few pages it refers to

Preview

For example, see:

@chalin chalin requested a review from a team as a code owner January 24, 2025 15:19
@opentelemetrybot opentelemetrybot requested review from a team January 24, 2025 15:19
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 15:19
@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team January 24, 2025 15:19
@chalin chalin changed the title Glossary: add terms from style guide, and rework a bit Glossary: add terms from style guide, and some rework Jan 24, 2025
@chalin chalin marked this pull request as draft January 24, 2025 15:26
@chalin chalin force-pushed the chalin-im-glossary++2025-01-24 branch from 1844c04 to a21480a Compare January 24, 2025 15:28
@chalin chalin marked this pull request as ready for review January 24, 2025 15:28
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 15:29
@chalin chalin force-pushed the chalin-im-glossary++2025-01-24 branch from a21480a to 7826ad0 Compare January 24, 2025 15:39
chalin
chalin commented Jan 24, 2025
View reviewed changes
content/ja/docs/concepts/glossary.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/docs-ja-approvers - FYI, I added placeholder entries to appease the link checker.

chalin
chalin commented Jan 24, 2025
View reviewed changes
content/pt/docs/concepts/glossary.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/docs-pt-approvers - FYI, I added placeholder entries to appease the link checker.

tiffany76
tiffany76 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, otherwise, LGTM.

content/en/docs/collector/management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 18:00
@chalin
Copy link
Contributor Author

chalin commented Jan 24, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12955162865

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin chalin force-pushed the chalin-im-glossary++2025-01-24 branch from 0758ca7 to 366ee3c Compare January 24, 2025 18:34
@chalin chalin merged commit f37118d into open-telemetry:main Jan 24, 2025
17 checks passed
@chalin chalin deleted the chalin-im-glossary++2025-01-24 branch January 24, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
cleanup/refactoring copyedit docs lang:ja lang:pt sig:collector
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @opentelemetrybot @tiffany76