Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce various info logs to debug #2700

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

Sushisource
Copy link
Contributor

Fixes #
Design discussion issue (if applicable) #2697

Changes

Reduce various recently introduced info level logs to debug.

Many of these are lifecycle related and unlikely to be interesting to most users.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@Sushisource Sushisource requested a review from a team as a code owner February 21, 2025 18:39
Copy link

linux-foundation-easycla bot commented Feb 21, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (bc5e6ce) to head (616b2d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 22.2% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2700   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22657   22657           
=====================================
+ Hits       17970   17974    +4     
+ Misses      4687    4683    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one place : https://github.com/open-telemetry/opentelemetry-rust/pull/2700/files#r1966362700
Once this is resolved, we are good to merge.

(Also, there is merge conflict due to changelog. Please resolve that too to merge)

@cijothomas cijothomas merged commit edab145 into open-telemetry:main Feb 24, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants