Calls to with_resource for signal builders (Metrics, Logs, Traces) are now additive
#2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
=======================================
+ Coverage 79.1% 79.2% +0.1%
=======================================
Files 122 122
Lines 22530 22621 +91
=======================================
+ Hits 17839 17934 +95
+ Misses 4691 4687 -4 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Feb 18, 2025
cijothomas
reviewed
Feb 18, 2025
cijothomas
requested changes
Feb 18, 2025
There was a problem hiding this comment.
I agree with this change. Requesting changes to address below.
- [Feature]: add ability for with_resource to merge Resources on providers #2324 (comment) - Check this and see if this makes sense, given there are more than one ideas suggested in the linked issue.
- Please make the change consistent across signals. (Okay to do that in separate PR to keep scope smaller)
lalitb
reviewed
Feb 18, 2025
lalitb
reviewed
Feb 18, 2025
lalitb
approved these changes
Feb 20, 2025
martintmk
force-pushed
the
additive_with_resource
branch
from
2fa8aa0 to
cfc37e6
Compare
martintmk
changed the title
MeterProviderBuilder::with_resource are now additivewith_resource for signal builders (Metrics, Logs, Traces) are now additive
cijothomas
reviewed
Feb 20, 2025
cijothomas
approved these changes
Feb 20, 2025
|
@martintmk Edited the PR Desc slightly to mark the associated issue to be resolved with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2324
Changes
The calls to:
MeterProviderBuilder::with_resourceTracerProviderBuilder::with_resourceLoggerProviderBuilder::with_resourceAre now additive and the previous resource is not discarded anymore. Additionally, I fixed a bug where setting the
schema_urlwas discarded due to a bug how merging of resources was handled.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes