Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example demonstrating the lock contention for metrics #2651

Closed

Conversation

martintmk
Copy link
Contributor

When looking at #1386 I wanted to practically demonstrate the lock contention for metrics and how it affects the performance.

To run the example using a shared MeterProvider:

cargo run --release -- shared

To run the example using a per-thread MeterProvider:

cargo run --release -- per-thread

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (eeb367d) to head (3e1c1bc).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2651     +/-   ##
=======================================
- Coverage   79.1%   79.0%   -0.2%     
=======================================
  Files        119     120      +1     
  Lines      22556   22512     -44     
=======================================
- Hits       17857   17791     -66     
- Misses      4699    4721     +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please leverage the existing stress test https://github.com/open-telemetry/opentelemetry-rust/tree/main/stress/src and add a new scenario which use per-thread provider.

@martintmk
Copy link
Contributor Author

martintmk commented Feb 13, 2025

Replaced by #2659

@martintmk martintmk closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants