Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psycopg: Patch server_cursor_factory #3181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamestjw
Copy link

@jamestjw jamestjw commented Jan 10, 2025

Description

When getting a cursor with a name, the Connection class produces a cursor using server_cursor_factory. However, this factory isn't instrumented.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I added unit tests that would fail without my changes.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jan 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jamestjw / name: James Tan (3334e74)

@github-actions github-actions bot requested a review from federicobond January 10, 2025 22:53
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch from 8cba3e6 to 5e11096 Compare January 10, 2025 22:54
@jamestjw jamestjw changed the title psycogpg: Patch server_cursor_factory psycopg: Patch server_cursor_factory Jan 10, 2025
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch 2 times, most recently from 2c90c1c to 15cab9e Compare January 13, 2025 20:50
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch from 15cab9e to 3334e74 Compare January 14, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants