-
Notifications
You must be signed in to change notification settings - Fork 882
Implement new SemConv exporter health metrics #7265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @JonasKunz give me a heads up when you think this is ready for review. Happy to start with a high level review while its still in draft! |
@jack-berg a high level review would be appreciated! I'm happy with the overall structure and would mostly polish from now on, so it would be great to get your feedback before I polish things we'll end up changing anyway. I've updated the PR comment to give an introduction on how I envision the feature implementation in general. |
This PR implements the new, experimental exporter health metrics defined in semantic conventions. The other metrics will be added in follow-up PRs.
This PR also already included metric-exporter health metrics which are part of an open semconv PR but I think that PR is close to reaching a consensus.
We already have some experimental health metrics in the SDK, which I intend to eventually replace with the new ones from semantic conventions. I'm envisioning the replacement process as follows:
on
,off
,legacy
and maybe in the futureextended
for opt-in attributes / metricslegacy
toon
, this will be a breaking changeThis PR is designed with the eventual removal of support for the legacy metrics in mind:
ExporterMetrics
classExporterMetricsAdapter
is available which mimics theExporterMetrics
api, but can fallback to reporting the legacy metrics insteadThis will allow us to easily remove the legacy metrics later on: Simply replace the usages of
ExporterMetricsAdapter
withExporterMetrics
and delete the adapter and related code.