fix: add guard against the ArrayIndexOutOfBoundsException in BaggageCodec… #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (71.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7239 +/- ##
============================================
- Coverage 89.95% 89.94% -0.01%
- Complexity 6685 6686 +1
============================================
Files 751 751
Lines 20191 20193 +2
Branches 1978 1980 +2
============================================
Hits 18162 18162
- Misses 1436 1437 +1
- Partials 593 594 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
breedx-splk
reviewed
Apr 2, 2025
| @@ -36,7 +36,6 @@ void shouldDecodePercentEncodedValues(String percentEncoded, String expectedDeco | |||
|
|
|||
| @Test | |||
| void shouldThrowIfMalformedData() { | |||
There was a problem hiding this comment.
Let's rename this because the behavior has changed. 👍🏻
breedx-splk
reviewed
Apr 2, 2025
| @@ -36,7 +36,6 @@ void shouldDecodePercentEncodedValues(String percentEncoded, String expectedDeco | |||
|
|
|||
| @Test | |||
| void shouldThrowIfMalformedData() { | |||
| assertThatThrownBy(() -> BaggageCodec.decode("%1", StandardCharsets.UTF_8)) | |||
| .isInstanceOf(IllegalArgumentException.class); | |||
| assertThatNoException().isThrownBy(() -> BaggageCodec.decode("%1", StandardCharsets.UTF_8)); | |||
There was a problem hiding this comment.
Can we also add a few chars and make sure that they come through in the output? In other words, lets assert on the result in addition to no exception being thrown. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added guard against the ArrayIndexOutOfBoundsException in BaggageCodec class