fix micrometer bridge auto configuration annotation #13083
Conversation
zeitlinger
changed the title
yes - I even found the test that I broke with this PR. |
zeitlinger
force-pushed
the
micrometer-bridge-auto-config
branch
from
a888249 to
b9a2ab1
Compare
| testing { | ||
| suites { | ||
| val testPrometheus by registering(JvmTestSuite::class) { | ||
| dependencies { | ||
| runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.14.3") | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
what's the failure for this test without your change to OpenTelemetryMeterRegistry?
There was a problem hiding this comment.
just tried... there is no failure - which confirms that the error does not always appear
but I've improved the test
There was a problem hiding this comment.
what's the failure now (without your change to OpenTelemetryMeterRegistry)?
There was a problem hiding this comment.
@trask the test is still passing with the unchanged code
I don't know how to force spring to use a different resolution order from the provided constraints
There was a problem hiding this comment.
the test is still passing the old code - but I don't have an idea how to make a better test - you'd have to force spring to randomize the bean order within the provided constraints
| @AutoConfigureAfter(SimpleMetricsExportAutoConfiguration.class) | ||
| @AutoConfigureAfter({ | ||
| SimpleMetricsExportAutoConfiguration.class, | ||
| PrometheusMetricsExportAutoConfiguration.class |
There was a problem hiding this comment.
is there a way to do this generically for all other MeterRegistries? (not only simple and prometheus?)
There was a problem hiding this comment.
do you want to add more different configs that load different metric registries? sounds too much - @jeanbisutti what's your take?
There was a problem hiding this comment.
no, asking if there's a way to do it generically, so that it loads after all other MeterRegistries, without having to hard-code specific meter registries
Fixes #12719 - hopefully