Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jaeger-idl/proto-gen/api_v2 #7061

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

javiermolinar
Copy link

@javiermolinar javiermolinar commented Mar 28, 2025

This pr tries to fix a panic when jaegerremote is used along with the OTEL collector

panic: proto: duplicate enum registered: jaeger.api_v2.SamplingStrategyType
      goroutine 1 [running]:
      github.com/gogo/protobuf/proto.RegisterEnum(...)
       /races/vendor/github.com/gogo/protobuf/proto/properties.go:520
      github.com/jaegertracing/jaeger-idl/proto-gen/api_v2.init.4()
       /traces/vendor/github.com/jaegertracing/jaeger-idl/proto-gen/api_v2/sampling.pb.go:432 +0x219
      )

It also fixes the example by using the jaegerremotesampling extension instead of the deprecated remote_sampling

@javiermolinar javiermolinar requested review from yurishkuro and a team as code owners March 28, 2025 09:51
Copy link

linux-foundation-easycla bot commented Mar 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@javiermolinar
Copy link
Author

@javiermolinar
Copy link
Author

I've added a line in the changelog :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants