style(internal/shared/semconv): Simplify request processing

[gaiaz-iusipov]

I suggest a few changes to request processing:

• Remove the redundant call to req.UserAgent().
• Replace strings.Index() calls with strings.IndexByte().
• Replace strings.LastIndex() calls with strings.LastIndexByte().

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (cddf5c6) to head (57445c7).

Files with missing lines	Patch %	Lines
...ei/go-restful/otelrestful/internal/semconv/util.go	75.0%	0 Missing and 1 partial ⚠️
...com/gin-gonic/gin/otelgin/internal/semconv/util.go	75.0%	0 Missing and 1 partial ⚠️
...b.com/gorilla/mux/otelmux/internal/semconv/util.go	75.0%	0 Missing and 1 partial ⚠️
...p/httptrace/otelhttptrace/internal/semconv/util.go	75.0%	0 Missing and 1 partial ⚠️
...ntation/net/http/otelhttp/internal/semconv/util.go	75.0%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #6990   +/-   ##
=====================================
  Coverage   75.8%   75.8%           
=====================================
  Files        207     207           
  Lines      19494   19494           
=====================================
+ Hits       14783   14786    +3     
+ Misses      4275    4273    -2     
+ Partials     436     435    -1     

Files with missing lines	Coverage Δ
...o-restful/otelrestful/internal/semconv/httpconv.go	86.9% <100.0%> (ø)
...gin-gonic/gin/otelgin/internal/semconv/httpconv.go	86.9% <100.0%> (ø)
...m/gorilla/mux/otelmux/internal/semconv/httpconv.go	86.9% <100.0%> (ø)
...tptrace/otelhttptrace/internal/semconv/httpconv.go	86.9% <100.0%> (ø)
...ion/net/http/otelhttp/internal/semconv/httpconv.go	86.9% <100.0%> (ø)
...ei/go-restful/otelrestful/internal/semconv/util.go	82.8% <75.0%> (ø)
...com/gin-gonic/gin/otelgin/internal/semconv/util.go	82.8% <75.0%> (ø)
...b.com/gorilla/mux/otelmux/internal/semconv/util.go	82.8% <75.0%> (ø)
...p/httptrace/otelhttptrace/internal/semconv/util.go	82.8% <75.0%> (ø)
...ntation/net/http/otelhttp/internal/semconv/util.go	82.8% <75.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gaiaz-iusipov]

Do I need to add anything to the changelog?

[dmathieu]

semconvutil will be dropped after the next release.
As for semconv, it will be refactored later on.

So I wouldn't focus on refactoring those packages at the moment.

[gaiaz-iusipov]

semconvutil will be dropped after the next release. As for semconv, it will be refactored later on.

So I wouldn't focus on refactoring those packages at the moment.

Thanks, can I close this pull request or keep a small part of the changes in the semconv package?

[dmathieu]

The semconv changes are small enough that we can keep them IMHO.