Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgin: Clean Route setup in otelgin HTTP instrumentation #6982

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arshukla98
Copy link

@arshukla98 arshukla98 commented Mar 25, 2025

Description:-

The intention of this PR is to resolve the issue #6976 .

Copy link

linux-foundation-easycla bot commented Mar 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from akats7 March 25, 2025 08:00
@arshukla98 arshukla98 force-pushed the Issue_6976 branch 2 times, most recently from f4b277d to 1b7cbb0 Compare March 25, 2025 12:11
@dmathieu dmathieu added the blocked: CLA Waiting on CLA to be signed before progress can be made label Mar 25, 2025
@arshukla98 arshukla98 closed this Mar 28, 2025
@arshukla98 arshukla98 reopened this Mar 28, 2025
@arshukla98 arshukla98 marked this pull request as ready for review March 28, 2025 09:16
@arshukla98 arshukla98 requested a review from a team as a code owner March 28, 2025 09:16
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (b0c0319) to head (849db54).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6982   +/-   ##
=====================================
  Coverage   75.8%   75.8%           
=====================================
  Files        207     207           
  Lines      19494   19493    -1     
=====================================
+ Hits       14783   14784    +1     
+ Misses      4275    4274    -1     
+ Partials     436     435    -1     
Files with missing lines Coverage Δ
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 92.9% <100.0%> (-0.1%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arshukla98 arshukla98 marked this pull request as draft March 28, 2025 09:26
@arshukla98 arshukla98 force-pushed the Issue_6976 branch 2 times, most recently from c4bdf47 to 8006d05 Compare March 28, 2025 09:41
@arshukla98 arshukla98 marked this pull request as ready for review March 28, 2025 09:41
@arshukla98 arshukla98 force-pushed the Issue_6976 branch 2 times, most recently from 849db54 to 5d43a11 Compare March 28, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: CLA Waiting on CLA to be signed before progress can be made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants