Renaming http utility lib to otel_http #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaothallis
reviewed
Aug 18, 2024
| @@ -1,4 +1,4 @@ | |||
| -module(opentelemetry_instrumentation_http). | |||
| -module(otel_http). | |||
|
|
|||
| -if(?OTP_RELEASE >= 27). | |||
| -define(MODULEDOC(Str), -moduledoc(Str)). | |||
There was a problem hiding this comment.
In line 42 there is a comment with opentelemetry_instrumentation_http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to rename the unused
opentelemetry_instrumentation_httplibrary tootel_httpas we think that namespace has no chance of collision in the API and the utility nature wouldn't pose an issue of moving anything should that ever happen.This should make DX nicer with the shorter name.