Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra metadata to add to telemetry events for Redix #262

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Extra metadata to add to telemetry events for Redix #262

wants to merge 4 commits into from

Conversation

prabhjotlalli
Copy link

These end up in :extra_metadata metadata key to pass along.

@prabhjotlalli
Extra metadata to add to telemetry events for Redix
e0b735e 
These end up in `:extra_metadata` metadata key to pass along.
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 31, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@bryannaegele
Copy link
Collaborator

Would folks always want all the metadata as attributes or just particular keys? I imagine folks would want more control.

@prabhjotlalli
Copy link
Author

@bryannaegele I went with passing along everything since it's what is expected by the library https://hexdocs.pm/redix/Redix.Telemetry.html

I'm open to having a set list of keys if you can point me to what we would want to limit it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
elixir instrumentation opentelemetry_redix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prabhjotlalli @bryannaegele