[exporter/prometheusremotewrite] Make WAL shutdown wait until goroutine exits #37733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entelemetry-service-contrib into fix-TestExportWithWALEnabled
ArthurSens
approved these changes
Feb 5, 2025
dashpole
approved these changes
Feb 6, 2025
dashpole
added
the
ready to merge
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…ne exits (open-telemetry#37733) #### Description When WAL is used the shutdown doesn't wait until the go routine launched to handle WAL terminates. This makes the shutdown non-deterministic and cause the test failure issues linked below. Although a bug on the component it doesn't seem to deserve a changelog since it was detected via tests and there is no open issue around the shutdown of the component. #### Link to tracking issue Fixes open-telemetry#9124, open-telemetry#37715 #### Testing Ran the component tests locally multiple times on Windows (more likely to surface concurrency issues). #### Documentation N/A
songy23
pushed a commit
that referenced
this pull request
Feb 10, 2025
…tch type prweWAL (#37781) #### Description While implementing #37733 I noticed that the pointer receiver to the methods of the `prweWAL` were `prwe`, however, this made harder to navigate the code since it was the same name of the receiver pointer used for the type `prweExporter`. Changing it to match the respective type makes easier to read and navigate the code. #### Testing Local lint and make. #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When WAL is used the shutdown doesn't wait until the go routine launched to handle WAL terminates. This makes the shutdown non-deterministic and cause the test failure issues linked below.
Although a bug on the component it doesn't seem to deserve a changelog since it was detected via tests and there is no open issue around the shutdown of the component.
Link to tracking issue
Fixes #9124, #37715
Testing
Ran the component tests locally multiple times on Windows (more likely to surface concurrency issues).
Documentation
N/A